git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 1/1] perl: fix installing modules from contrib

From
Christian Hesse <mail@eworm.de>
Date
Apr 10, 2018, 13:36 UTC
Message-ID
<20180410133641.18861-1-mail@eworm.de>
In-Reply-To
<xmqqpo39569k.fsf@gitster-ct.c.googlers.com>

Commit 20d2a30f (Makefile: replace perl/Makefile.PL with simple make rules) removed a target that allowed Makefiles from contrib/ to get the correct install path. This introduces a new target for main Makefile and fixes installation for Mediawiki module.

v2: Pass prefix as that can have influence as well, add single quotes
    for _SQ variant.
Signed-off-by: Christian Hesse <mail@eworm.de>
---
 Makefile                   | 2 ++
 contrib/mw-to-git/Makefile | 5 +++--
 2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 96f6138f6..19ca5e8de 100644
--- a/Makefile
+++ b/Makefile
@@ -2011,6 +2011,8 @@ GIT-PERL-DEFINES: FORCE
 		echo "$$FLAGS" >$@; \
 	    fi
 
+perllibdir:
+	@echo '$(perllibdir_SQ)'
 
 .PHONY: gitweb
 gitweb:
diff --git a/contrib/mw-to-git/Makefile b/contrib/mw-to-git/Makefile
index a4b6f7a2c..4e603512a 100644
--- a/contrib/mw-to-git/Makefile
+++ b/contrib/mw-to-git/Makefile
@@ -21,8 +21,9 @@ HERE=contrib/mw-to-git/
 INSTALL = install
 
 SCRIPT_PERL_FULL=$(patsubst %,$(HERE)/%,$(SCRIPT_PERL))
-INSTLIBDIR=$(shell $(MAKE) -C $(GIT_ROOT_DIR)/perl \
-                -s --no-print-directory instlibdir)
+INSTLIBDIR=$(shell $(MAKE) -C $(GIT_ROOT_DIR)/ \
+                -s --no-print-directory prefix=$(prefix) \
+                perllibdir=$(perllibdir) perllibdir)
 DESTDIR_SQ = $(subst ','\'',$(DESTDIR))
 INSTLIBDIR_SQ = $(subst ','\'',$(INSTLIBDIR))
 
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 8 in “perl: fix installing modules from contrib”
  1. 1/1 perl: fix installing modules from contribChristian Hesse, Apr 3, 2018
  2. Ævar Arnfjörð BjarmasonApr 3, 2018
  3. Junio C HamanoApr 9, 2018
  4. 1/1 perl: fix installing modules from contribChristian Hesse, Apr 10, 2018
  5. Junio C HamanoApr 10, 2018
  6. 1/1 perl: fix installing modules from contribChristian Hesse, Apr 11, 2018
  7. Junio C HamanoApr 18, 2018
  8. Christian HesseApr 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.