Re: [PATCH] send-email: fix docs regarding storing password with git credential

From: Jeff King <peff@peff.net>
Date: Apr 4, 2018, 21:14 UTC
Message-ID: <20180404211446.GC15402@sigill.intra.peff.net>
In-Reply-To: <20180402232348.20293-1-mina86@mina86.com>

On Tue, Apr 03, 2018 at 12:23:48AM +0100, Michal Nazarewicz wrote:

> First of all, ‘git credential fill’ does not store credentials
> but is used to *read* them.  The command which adds credentials
> to the helper’s store is ‘git credential approve’.

Yep, makes sense (I wish we had just called these consistently "get", "store", and "erase" as they are in the git<->helper interface).

Show 6 quoted lines

> Second of all, git-send-email will include port number in host
> parameter when getting the password so it has to be set when
> storing the password as well.
> 
> Apply the two above to fix the Gmail example in git-send-email
> documentation.

Makes sense. This is an interesting counter-example to my earlier "well, it usually works out in the long run" statement. Because usually you're relying on some part of Git to issue the "fill" and the "approve", so whatever it uses, it will be the same. But here we're trying to pre-seed, so we have to match what the tool will do.

On the other hand, I'm not sure why we need to pre-seed here. Wouldn't it be sufficient to just issue a "git send-email", which would then prompt for the password? And then you'd input your generated token, which would get saved via the approve mechanism?

-Peff