[PATCH] send-email: fix docs regarding storing password with git credential
- From
Michal Nazarewicz <mina86@mina86.com>
- Date
- Apr 2, 2018, 23:23 UTC
- Message-ID
- <20180402232348.20293-1-mina86@mina86.com>
- In-Reply-To
- <xmqqk1tpxo0g.fsf@gitster-ct.c.googlers.com>
First of all, ‘git credential fill’ does not store credentials but is used to *read* them. The command which adds credentials to the helper’s store is ‘git credential approve’.
Second of all, git-send-email will include port number in host parameter when getting the password so it has to be set when storing the password as well.
Apply the two above to fix the Gmail example in git-send-email documentation.
Signed-off-by: Michał Nazarewicz <mina86@mina86.com> --- Documentation/git-send-email.txt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt index 71ef97ba9..172c7b344 100644 --- a/Documentation/git-send-email.txt +++ b/Documentation/git-send-email.txt @@ -477,13 +477,12 @@ https://security.google.com/settings/security/apppasswords to setup an app-specific password. Once setup, you can store it with the credentials helper: - $ git credential fill + $ git credential approve protocol=smtp - host=smtp.gmail.com + host=smtp.gmail.com:587 username=youname@gmail.com password=app-password - Once your commits are ready to be sent to the mailing list, run the following commands:
-- 2.16.2