Re: [PATCH v2 2/2] stash push -u: don't create empty stash

From: Thomas Gummerer <t.gummerer@gmail.com>
Date: Mar 16, 2018, 20:10 UTC
Message-ID: <20180316201034.GA2224@hank>
In-Reply-To: <xmqqtvth3xt5.fsf@gitster-ct.c.googlers.com>

On 03/15, Junio C Hamano wrote:

Show 9 quoted lines

> Thomas Gummerer <t.gummerer@gmail.com> writes:
> 
> >  no_changes () {
> >  	git diff-index --quiet --cached HEAD --ignore-submodules -- "$@" &&
> >  	git diff-files --quiet --ignore-submodules -- "$@" &&
> > -	(test -z "$untracked" || test -z "$(untracked_files)")
> > +	(test -z "$untracked" || test -z "$(untracked_files $@)")
> 
> Don't you need a pair of double-quotes around that $@?

Ah yes indeed.  Will fix, thanks!

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.