From: Thomas Gummerer Date: Fri, 16 Mar 2018 20:10:34 GMT Subject: Re: [PATCH v2 2/2] stash push -u: don't create empty stash Message-ID: <20180316201034.GA2224@hank> In-Reply-To: On 03/15, Junio C Hamano wrote: > Thomas Gummerer writes: > > > no_changes () { > > git diff-index --quiet --cached HEAD --ignore-submodules -- "$@" && > > git diff-files --quiet --ignore-submodules -- "$@" && > > - (test -z "$untracked" || test -z "$(untracked_files)") > > + (test -z "$untracked" || test -z "$(untracked_files $@)") > > Don't you need a pair of double-quotes around that $@? Ah yes indeed. Will fix, thanks!