Re: t006 broken under Mac OS

From: Jeff King <peff@peff.net>
Date: Mar 3, 2018, 14:27 UTC
Message-ID: <20180303142747.GA28218@sigill.intra.peff.net>
In-Reply-To: <f711d7ea-b3a0-82c4-6700-5ec285c91115@web.de>

On Sat, Mar 03, 2018 at 01:52:05PM +0100, Torsten Bögershausen wrote:

Show 14 quoted lines

> Beside that t1006 has a broken indentation (mixed spaces and TABs at
>  the beginning of the line, I get 4 errors here under Mac OS:
> 
> not ok 15 - Check %(refname) gives empty output
> not ok 36 - Check %(refname) gives empty output
> not ok 58 - Check %(refname) gives empty output
> not ok 89 - Check %(refname) gives empty output
> 
> 
> Running with debug and verbose shows that the empty files are not empty.
> The characters in the non-empty file are outside the ASCII range,
> so I copy  the stuff in here after running `od -c`  on the log file.
> And I don't have a clue, where this stuff comes from - but I get different
> "crap" with each run - seams as if there is a read behind a buffer ?

Yeah, I think the ref_array_item.refname flex-parameter is not valid. This is the same issue Ramsay mentioned in:

  https://public-inbox.org/git/58b2bdcd-d621-fd21-ab4d-6a9478319b19@ramsayjones.plus.com/

Junio, I think it probably makes sense to eject ot/cat-batch-format from pu for now. That series is on pause for a bit while Olga works on some other refactoring, and it's causing problems for people who test pu regularly.

-Peff