threads / discuss / 47970

t006 broken under Mac OS

Subject: t006 broken under Mac OS

## tl;dr

3 messages between Mar 3, 2018 and Mar 5, 2018.

replies: 2people: 3as markdown or json

Torsten Bögershausen· Mar 3, 2018, 12:52 UTC · lore
Hej,
Beside that t1006 has a broken indentation (mixed spaces and TABs at
 the beginning of the line, I get 4 errors here under Mac OS:

not ok 15 - Check %(refname) gives empty output not ok 36 - Check %(refname) gives empty output not ok 58 - Check %(refname) gives empty output not ok 89 - Check %(refname) gives empty output

Running with debug and verbose shows that the empty files are not empty. The characters in the non-empty file are outside the ASCII range, so I copy the stuff in here after running `od -c` on the log file. And I don't have a clue, where this stuff comes from - but I get different "crap" with each run - seams as if there is a read behind a buffer ?

15: 0006000 0 \n @ @ - 1 + 1 @ @ \n - \n 0006020 + 361 r 0 360 024 254 \n n o t o k 1 0006040 5 - C h e c k % ( r e f n 0006060 a m e ) g i v e s e m p t y 0006100 o u t p u t \n # \t \n # \t \t e c

36: 0016220 - 1 + 1 @ @ \n - \n + 225 x < e 0016240 240 @ \n n o t o k 3 6 - C 0016260 h e c k % ( r e f n a m e ) 0016300 g i v e s e m p t y o u t p 0016320 u t \n # \t \n # \t \t e c h o " $

58: 0027120 \n @ @ - 1 + 1 @ @ \n - \n + 0027140 302 206 \a 4 220 311 \n n o t o k 5 8 0027160 - C h e c k % ( r e f n a 0027200 m e ) g i v e s e m p t y 0027220 o u t p u t \n # \t \n # \t \t e c h

89: 0043160 0 0 0 \n @ @ - 1 + 1 @ @ \n 0043200 - \n + p 034 276 034 ! ; \n n o t o k 0043220 8 9 - C h e c k % ( r e 0043240 f n a m e ) g i v e s e m p 0043260 t y o u t p u t \n # \t \n # \t \t

Jeff King· Mar 3, 2018, 14:27 UTC · re: Torsten Bögershausen · lore

Re: t006 broken under Mac OS

On Sat, Mar 03, 2018 at 01:52:05PM +0100, Torsten Bögershausen wrote:
Show 14 quoted lines
> Beside that t1006 has a broken indentation (mixed spaces and TABs at
>  the beginning of the line, I get 4 errors here under Mac OS:
> 
> not ok 15 - Check %(refname) gives empty output
> not ok 36 - Check %(refname) gives empty output
> not ok 58 - Check %(refname) gives empty output
> not ok 89 - Check %(refname) gives empty output
> 
> 
> Running with debug and verbose shows that the empty files are not empty.
> The characters in the non-empty file are outside the ASCII range,
> so I copy  the stuff in here after running `od -c`  on the log file.
> And I don't have a clue, where this stuff comes from - but I get different
> "crap" with each run - seams as if there is a read behind a buffer ?

Yeah, I think the ref_array_item.refname flex-parameter is not valid. This is the same issue Ramsay mentioned in:

  https://public-inbox.org/git/58b2bdcd-d621-fd21-ab4d-6a9478319b19@ramsayjones.plus.com/

Junio, I think it probably makes sense to eject ot/cat-batch-format from pu for now. That series is on pause for a bit while Olga works on some other refactoring, and it's causing problems for people who test pu regularly.

-Peff
Junio C Hamano· Mar 5, 2018, 21:34 UTC · re: Jeff King · lore

Re: t006 broken under Mac OS

Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> Yeah, I think the ref_array_item.refname flex-parameter is not valid.
> This is the same issue Ramsay mentioned in:
>
>   https://public-inbox.org/git/58b2bdcd-d621-fd21-ab4d-6a9478319b19@ramsayjones.plus.com/
>
> Junio, I think it probably makes sense to eject ot/cat-batch-format from
> pu for now. That series is on pause for a bit while Olga works on some
> other refactoring, and it's causing problems for people who test pu
> regularly.
Yup, thanks for a reminder.

← back to recent threads