git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 27/36] builtin/fmt-merge-msg: convert remaining code to object_id

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 19, 2018, 22:59 UTC
Message-ID
<20180219225927.386065-28-sandals@crustytoothpaste.net>
In-Reply-To
<20180219225927.386065-1-sandals@crustytoothpaste.net>

We were using the util pointer, which is a pointer to void, as an unsigned char pointer. The pointer actually points to a struct origin_data, which has a struct object_id as its first member, which in turn has an unsigned char array as its first member, so this was valid. Since we want to convert this to struct object_id, simply change the pointer we're using.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
---
 builtin/fmt-merge-msg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/fmt-merge-msg.c b/builtin/fmt-merge-msg.c
index 8e8a15ea4a..0bc0dda99c 100644
--- a/builtin/fmt-merge-msg.c
+++ b/builtin/fmt-merge-msg.c
@@ -485,10 +485,10 @@ static void fmt_merge_msg_sigs(struct strbuf *out)
 	struct strbuf tagbuf = STRBUF_INIT;
 
 	for (i = 0; i < origins.nr; i++) {
-		unsigned char *sha1 = origins.items[i].util;
+		struct object_id *oid = origins.items[i].util;
 		enum object_type type;
 		unsigned long size, len;
-		char *buf = read_sha1_file(sha1, &type, &size);
+		char *buf = read_sha1_file(oid->hash, &type, &size);
 		struct strbuf sig = STRBUF_INIT;
 
 		if (!buf || type != OBJ_TAG)
Previous: brian m. carlsonNext: brian m. carlson
Message 25 of 39 in “object_id part 12”
  1. 00/36 object_id part 12brian m. carlson, Feb 19, 2018
  2. 01/36 bulk-checkin: convert index_bulk_checkin to struct object_idbrian m. carlson, Feb 19, 2018
  3. 02/36 builtin/write-tree: convert to struct object_idbrian m. carlson, Feb 19, 2018
  4. 03/36 cache-tree: convert write_*_as_tree to object_idbrian m. carlson, Feb 19, 2018
  5. 07/36 ref-filter: convert grab_objectname to struct object_idbrian m. carlson, Feb 19, 2018
  6. 13/36 replace_object: convert struct replace_object to object_idbrian m. carlson, Feb 19, 2018
  7. 14/36 builtin/mktag: convert to struct object_idbrian m. carlson, Feb 19, 2018
  8. 18/36 sha1_file: convert read_loose_object to use struct object_idbrian m. carlson, Feb 19, 2018
  9. 20/36 streaming: convert open_istream to use struct object_idbrian m. carlson, Feb 19, 2018
  10. 21/36 builtin/mktree: convert to struct object_idbrian m. carlson, Feb 19, 2018
  11. 24/36 packfile: convert unpack_entry to struct object_idbrian m. carlson, Feb 19, 2018
  12. 22/36 sha1_file: convert assert_sha1_type to object_idbrian m. carlson, Feb 19, 2018
  13. 29/36 tree-walk: convert get_tree_entry_follow_symlinks internals to object_idbrian m. carlson, Feb 19, 2018
  14. 31/36 tree-walk: convert tree entry functions to object_idbrian m. carlson, Feb 19, 2018
  15. 32/36 sha1_file: convert read_object_with_reference to object_idbrian m. carlson, Feb 19, 2018
  16. 35/36 sha1_file: introduce a constant for max header lengthbrian m. carlson, Feb 19, 2018
  17. 33/36 sha1_file: convert read_sha1_file to struct object_idbrian m. carlson, Feb 19, 2018
  18. 34/36 Convert lookup_replace_object to struct object_idbrian m. carlson, Feb 19, 2018
  19. 23/36 sha1_file: convert retry_bad_packed_offset to struct object_idbrian m. carlson, Feb 19, 2018
  20. 28/36 builtin/notes: convert static functions to object_idbrian m. carlson, Feb 19, 2018
  21. 30/36 streaming: convert istream internals to struct object_idbrian m. carlson, Feb 19, 2018
  22. 36/36 convert: convert to struct object_idbrian m. carlson, Feb 19, 2018
  23. 25/36 Convert remaining callers of sha1_object_info_extended to object_idbrian m. carlson, Feb 19, 2018
  24. 26/36 sha1_file: convert sha1_object_info* to object_idbrian m. carlson, Feb 19, 2018
  25. 27/36 builtin/fmt-merge-msg: convert remaining code to object_idbrian m. carlson, Feb 19, 2018
  26. 19/36 sha1_file: convert check_sha1_signature to struct object_idbrian m. carlson, Feb 19, 2018
  27. 17/36 builtin/index-pack: convert struct ref_delta_entry to object_idbrian m. carlson, Feb 19, 2018
  28. 06/36 tree: convert read_tree_recursive to struct object_idbrian m. carlson, Feb 19, 2018
  29. 15/36 archive: convert write_archive_entry_fn_t to object_idbrian m. carlson, Feb 19, 2018
  30. 16/36 archive: convert sha1_file_to_archive to struct object_idbrian m. carlson, Feb 19, 2018
  31. 09/36 wt-status: convert struct wt_status_state to object_idbrian m. carlson, Feb 19, 2018
  32. 12/36 send-pack: convert remaining functions to struct object_idbrian m. carlson, Feb 19, 2018
  33. 08/36 strbuf: convert strbuf_add_unique_abbrev to use struct object_idbrian m. carlson, Feb 19, 2018
  34. 05/36 resolve-undo: convert struct resolve_undo_info to object_idbrian m. carlson, Feb 19, 2018
  35. 04/36 cache-tree: convert remnants to struct object_idbrian m. carlson, Feb 19, 2018
  36. 10/36 Convert find_unique_abbrev* to struct object_idbrian m. carlson, Feb 19, 2018
  37. 11/36 http-walker: convert struct object_request to use struct object_idbrian m. carlson, Feb 19, 2018
  38. Junio C HamanoFeb 21, 2018
  39. brian m. carlsonFeb 22, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.