git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] minor test-hashmap fixes

From
Jeff King <peff@peff.net>
Date
Feb 14, 2018, 18:48 UTC
Message-ID
<20180214184846.GA13369@sigill.intra.peff.net>
In-Reply-To
<CAGZ79kZ5a1-znO_efwVbrRpXwboZHeiC+4PqB0SDR2Xwv5P+8g@mail.gmail.com>
On Wed, Feb 14, 2018 at 10:41:35AM -0800, Stefan Beller wrote:
> I have lost track of the hashmap improvements lately, but with
> such a good test helper, we could reduce the amount of
> commented code in hashmap.h and just link to the test helper?
> (as an extra step after this series, I thought we already had that)

Yeah, the example code in hashmap.h looks to be more or less the same thing as what's here (it maps a long to a value, which simplifies the FLEX_ARRAY bits, but I think it serves equally well as a reference).

I'd also be fine with drastically simplifying the example in hashmap.h, and letting test-hashmap serve as a more fleshed-out example (we don't need to see the main and scanf bits there).

-Peff
Previous: Stefan Beller
Message 11 of 11 in “minor test-hashmap fixes”
  1. 0/6 minor test-hashmap fixesJeff King, Feb 14, 2018
  2. 1/6 test-hashmap: use ALLOC_ARRAY rather than bare mallocJeff King, Feb 14, 2018
  3. Code AIFeb 14, 2018
  4. 2/6 test-hashmap: check allocation computation for overflowJeff King, Feb 14, 2018
  5. 3/6 test-hashmap: use xsnprintf rather than snprintfJeff King, Feb 14, 2018
  6. 4/6 test-hashmap: use strbuf_getline rather than fgetsJeff King, Feb 14, 2018
  7. 5/6 test-hashmap: simplify alloc_test_entryJeff King, Feb 14, 2018
  8. Junio C HamanoFeb 14, 2018
  9. 6/6 test-hashmap: use "unsigned int" for hash storageJeff King, Feb 14, 2018
  10. Stefan BellerFeb 14, 2018
  11. Jeff KingFeb 14, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.