[PATCH 6/6] test-hashmap: use "unsigned int" for hash storage
- From
Jeff King <peff@peff.net>
- Date
- Feb 14, 2018, 18:08 UTC
- Message-ID
- <20180214180857.GF9919@sigill.intra.peff.net>
- In-Reply-To
- <20180214180322.GA9190@sigill.intra.peff.net>
The hashmap API always use an unsigned value for storing and comparing hashes. Whereas this test code uses "int". This works out in practice since one can typically round-trip between "int" and "unsigned int". But since this is essentially reference code for the hashmap API, we should model using the correct types.
Signed-off-by: Jeff King <peff@peff.net> --- t/helper/test-hashmap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/helper/test-hashmap.c b/t/helper/test-hashmap.c index 56efff36e8..9ae9281c07 100644 --- a/t/helper/test-hashmap.c +++ b/t/helper/test-hashmap.c @@ -30,7 +30,8 @@ static int test_entry_cmp(const void *cmp_data, return strcmp(e1->key, key ? key : e2->key); } -static struct test_entry *alloc_test_entry(int hash, char *key, char *value) +static struct test_entry *alloc_test_entry(unsigned int hash, + char *key, char *value) { size_t klen = strlen(key); size_t vlen = strlen(value); @@ -156,7 +157,7 @@ int cmd_main(int argc, const char **argv) /* process commands from stdin */ while (strbuf_getline(&line, stdin) != EOF) { char *cmd, *p1 = NULL, *p2 = NULL; - int hash = 0; + unsigned int hash = 0; struct test_entry *entry; /* break line into command and up to two parameters */
-- 2.16.1.464.gc4bae515b7