Re: [PATCH] CodingGuidelines: mention "static" and "extern"

From: Jonathan Tan <jonathantanmy@google.com>
Date: Feb 9, 2018, 19:07 UTC
Message-ID: <20180209110738.edbc7a700b689db6967ec86a@google.com>
In-Reply-To: <CAPig+cT_ddVSEvdnMTNhtxWJMm4=DLyq8-hSDXa5X0i6rXa3xA@mail.gmail.com>

On Thu, 8 Feb 2018 18:14:06 -0500 Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 20 quoted lines

> On Thu, Feb 8, 2018 at 4:38 PM, Jeff King <peff@peff.net> wrote:
> > Subject: [PATCH] CodingGuidelines: mention "static" and "extern"
> > [...]
> >
> > Signed-off-by: Jeff King <peff@peff.net>
> > ---
> > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> > @@ -386,6 +386,11 @@ For C programs:
> > + - Variables and functions local to a given source file should be marked
> > +   with "static". Variables that are visible to other source files
> > +   must be declared with "extern" in header files. However, function
> > +   declarations should not use "extern", as that is already the default.
> 
> Perhaps:
> 
>     ... as that is already the default, unless declarations in the
>     header are already "extern", in which case consistency
>     may favor mirroring existing usage.
> 
> or something.

I would prefer not mirroring existing usage in this case - I think it's better if the code becomes eventually consistent in not using extern.