git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] minor GETTEXT_POISON fixes

From
Jeff King <peff@peff.net>
Date
Feb 6, 2018, 11:22 UTC
Message-ID
<20180206112255.GB32319@sigill.intra.peff.net>
In-Reply-To
<FA353B2B-A5D1-4E2C-A016-38066F611BDB@gmail.com>
On Tue, Feb 06, 2018 at 10:06:53AM +0100, Lars Schneider wrote:
Show 9 quoted lines
> 
> > On 06 Feb 2018, at 09:42, Jeff King <peff@peff.net> wrote:
> > 
> > I set NO_GETTEXT=1 in my config.mak, and happened to notice that running
> > the tests with GETTEXT_POISON fails. I think this has been broken for
> > years, but I don't generally play with GETTEXT_POISON. ;)
> 
> On Travis we run GETTEXT_POISON with gettext installed.
> What do you think about an additional job with GETTEXT_POISON and NO_GETTEXT=1?
I think it's probably a waste of CPU. ;)

It would be running the whole test suite to fix this one particular bug, which I don't think is pretty likely to regress (at least not more than any other bug). Whereas running with GETTEXT_POISON is meant to shake out strings that maybe shouldn't be translated, which is a very likely bug to get introduced.

-Peff
Previous: Lars Schneider
Message 5 of 5 in “minor GETTEXT_POISON fixes”
  1. 0/2 minor GETTEXT_POISON fixesJeff King, Feb 6, 2018
  2. 1/2 t0205: drop redundant testJeff King, Feb 6, 2018
  3. 2/2 git-sh-i18n: check GETTEXT_POISON before USE_GETTEXT_SCHEMEJeff King, Feb 6, 2018
  4. Lars SchneiderFeb 6, 2018
  5. Jeff KingFeb 6, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.