[PATCH 1/2] t0205: drop redundant test
- From
Jeff King <peff@peff.net>
- Date
- Feb 6, 2018, 08:43 UTC
- Message-ID
- <20180206084318.GA26329@sigill.intra.peff.net>
- In-Reply-To
- <20180206084226.GA26237@sigill.intra.peff.net>
We check that a shell variable is non-empty, and then we check that it's equal to a particular value. Just checking the latter covers both cases.
I suspect the original was trying to give better output when the test fails, but using "-x" covers that these days.
Signed-off-by: Jeff King <peff@peff.net> --- t/t0205-gettext-poison.sh | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/t/t0205-gettext-poison.sh b/t/t0205-gettext-poison.sh index 2361590d54..438e778d6a 100755 --- a/t/t0205-gettext-poison.sh +++ b/t/t0205-gettext-poison.sh @@ -7,10 +7,6 @@ test_description='Gettext Shell poison' . ./lib-gettext.sh -test_expect_success GETTEXT_POISON "sanity: \$GIT_INTERNAL_GETTEXT_SH_SCHEME is set (to $GIT_INTERNAL_GETTEXT_SH_SCHEME)" ' - test -n "$GIT_INTERNAL_GETTEXT_SH_SCHEME" -' - test_expect_success GETTEXT_POISON 'sanity: $GIT_INTERNAL_GETTEXT_SH_SCHEME" is poison' ' test "$GIT_INTERNAL_GETTEXT_SH_SCHEME" = "poison" '
-- 2.16.1.273.gc07cfcd8c9