Re: t9128 failing randomly with svn 1.9?
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Jan 30, 2018, 00:25 UTC
- Message-ID
- <20180130002539.GO431130@genre.crustytoothpaste.net>
- In-Reply-To
- <20180129120627.al2xvx4yhhvwn6ih@untitled>
On Mon, Jan 29, 2018 at 12:06:27PM +0000, Eric Wong wrote:
Show 14 quoted lines
> Todd Zullinger <tmz@pobox.com> wrote:
> diff --git a/git-svn.perl b/git-svn.perl
> index 76a75d0b3d..2ba14269bb 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1200,6 +1200,11 @@ sub cmd_branch {
> $ctx->copy($src, $rev, $dst)
> unless $_dry_run;
>
> + # Release resources held by ctx before creating another SVN::Ra
> + # so destruction is orderly. This seems necessary Subversion 1.9.5
> + # to avoid segfaults.
> + $ctx = undef;
> +This may be the right thing to do. I've seen a decent number of cases in Perl where global destruction randomly causes segfaults.
Show 8 quoted lines
> $gs->fetch_all; > } > > > I'll be looping t9128, t9141 and t9167 with that for a few > hours or day. Will report back sooner if it fails. > I'm on an ancient 32-bit system, I guess you guys encountered > it on 64-bit machines?
Yes, both systems are 64-bit Debian systems, one stable, and the other unstable.
-- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204