Re: t9128 failing randomly with svn 1.9?

From: Todd Zullinger <tmz@pobox.com>
Date: Jan 29, 2018, 02:58 UTC
Message-ID: <20180129025812.GD1427@zaya.teonanacatl.net>
In-Reply-To: <20180129015134.GN431130@genre.crustytoothpaste.net>

brian m. carlson wrote:

Show 22 quoted lines

> While running tests for my object_id part 11 series, I noticed a random
> segfault in git svn while running t9128.  I've reproduced this on a
> different machine as well, using both Subversion 1.9.5 and 1.9.7 (Debian
> stable and unstable).  It is reproducible on master.
> 
> When the test fails, it fails on the "git svn tag tag3" step, and I get
> the following:
> 
> Copying file:///home/bmc/checkouts/git/t/trash%20directory.t9128-git-svn-cmd-branch/svnrepo/trunk at r2 to file:///home/bmc/checkouts/git/t/trash%20directory.t9128-git-svn-cmd-branch/svnrepo/tags/tag3...
> Found possible branch point: file:///home/bmc/checkouts/git/t/trash%20directory.t9128-git-svn-cmd-branch/svnrepo/trunk => file:///home/bmc/checkouts/git/t/trash%20directory.t9128-git-svn-cmd-branch/svnrepo/tags/tag3, 2
> Found branch parent: (refs/remotes/origin/tags/tag3) 0604824a81a121ad05aaf8caea65d8ca8f86c018
> Following parent with do_switch
> Successfully followed parent
> r7 = f8467f2cee3bcead03e84cb51cf44f467a87457d (refs/remotes/origin/tags/tag3)
> error: git-svn died of signal 11
> 
> Doing the following three times, I had two crashes.
> 
> (set -e; for i in $(seq 1 20); do (cd t && ./t9128-git-svn-cmd-branch.sh --verbose); done)
> 
> I'm not really familiar with git svn or its internals, and I didn't see
> anything recently on the list about this.  Is this issue known?

I see the same test fail randomly on Fedora (and I think on CentOS/RHEL, but I run the full tests more often on Fedora).

For me, it's tests 3 and 4 which fail with the same error. I thought it was a failure in subversion or the perl bindings rather than git, so I simply disabled them in the Fedora builds. The Debian packages skip 9128 as well (and 9167, which fails similarly).

I've seen the failures in t9141 from 'git svn branch' as well. I made a note to re-enable those tests after Jeff's work to make it easier to run with shell tracing enabled by default, but have not done so yet.

The 'git svn' tests are not run in Travis because the perl subversion bindings are not installed. I haven't made time to try installing them and running the tests in Travis to see if the failures occur there, but I suspect they would.

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Going to trial with a lawyer who considers your whole life-style a
Crime in Progress is not a happy prospect.
    -- Hunter S. Thompson