Re: [PATCH v2 03/18] ref-filter: make valid_atom as function parameter
- From
Jeff King <peff@peff.net>
- Date
- Jan 19, 2018, 20:12 UTC
- Message-ID
- <20180119201256.GB10197@sigill.intra.peff.net>
- In-Reply-To
- <xmqq4lnhr8gy.fsf@gitster.mtv.corp.google.com>
On Fri, Jan 19, 2018 at 10:47:57AM -0800, Junio C Hamano wrote:
Show 13 quoted lines
> Jeff King <peff@peff.net> writes: > > > I also think %(deltabase) does make sense for anything that points to an > > object. I suspect it's not all that _useful_ for for-each-ref, but that > > doesn't mean we can't return the sensible thing if somebody asks for it. > > This may not be a new issue (or any issue at all), but is the > ability to learn deltabase make any sense in the first place? > > What should the code do when an object has three copies in the > repo, i.e. one as a base object (or a loose one), another as a > delta against an object, and the third one as a delta against > a different object?
This was a known issue when I introduced %(deltabase). The documentation explicitly calls this out and makes no promises about which copy we describe.
The %(objectsize:disk) atom has the same issue, too. See the CAVEATS section of git-cat-file(1).
-Peff