git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 04/18] cat-file: move struct expand_data into ref-filter

From
Olga Telezhnaya <olyatelezhnaya@gmail.com>
Date
Jan 10, 2018, 09:36 UTC
Message-ID
<01020160df6dc532-75f3ef78-26cb-4751-9ded-eb0e8d23833b-000000@eu-west-1.amazonses.com>
In-Reply-To
<01020160df6dc499-0e6d11ec-1dcd-4a71-997b-ea231f33fae4-000000@eu-west-1.amazonses.com>

Need that for further reusing of formatting logic in cat-file. Have plans to get rid of using expand_data in cat-file at all, and use it only in ref-filter for collecting, formatting and printing needed data.

Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com>
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored by: Jeff King <peff@peff.net>
---
 builtin/cat-file.c | 36 ------------------------------------
 ref-filter.h       | 36 ++++++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+), 36 deletions(-)
diff --git a/builtin/cat-file.c b/builtin/cat-file.c
index 7655a9a726773..7fd5b960ad698 100644
--- a/builtin/cat-file.c
+++ b/builtin/cat-file.c
@@ -176,42 +176,6 @@ static int cat_one_file(int opt, const char *exp_type, const char *obj_name,
 	return 0;
 }
 
-struct expand_data {
-	struct object_id oid;
-	enum object_type type;
-	unsigned long size;
-	off_t disk_size;
-	const char *rest;
-	struct object_id delta_base_oid;
-
-	/*
-	 * If mark_query is true, we do not expand anything, but rather
-	 * just mark the object_info with items we wish to query.
-	 */
-	int mark_query;
-
-	/*
-	 * Whether to split the input on whitespace before feeding it to
-	 * get_sha1; this is decided during the mark_query phase based on
-	 * whether we have a %(rest) token in our format.
-	 */
-	int split_on_whitespace;
-
-	/*
-	 * After a mark_query run, this object_info is set up to be
-	 * passed to sha1_object_info_extended. It will point to the data
-	 * elements above, so you can retrieve the response from there.
-	 */
-	struct object_info info;
-
-	/*
-	 * This flag will be true if the requested batch format and options
-	 * don't require us to call sha1_object_info, which can then be
-	 * optimized out.
-	 */
-	unsigned skip_object_info : 1;
-};
-
 static int is_atom(const char *atom, const char *s, int slen)
 {
 	int alen = strlen(atom);
diff --git a/ref-filter.h b/ref-filter.h
index 0d98342b34319..16d00e4b1bded 100644
--- a/ref-filter.h
+++ b/ref-filter.h
@@ -72,6 +72,42 @@ struct ref_filter {
 		verbose;
 };
 
+struct expand_data {
+	struct object_id oid;
+	enum object_type type;
+	unsigned long size;
+	off_t disk_size;
+	const char *rest;
+	struct object_id delta_base_oid;
+
+	/*
+	 * If mark_query is true, we do not expand anything, but rather
+	 * just mark the object_info with items we wish to query.
+	 */
+	int mark_query;
+
+	/*
+	 * Whether to split the input on whitespace before feeding it to
+	 * get_sha1; this is decided during the mark_query phase based on
+	 * whether we have a %(rest) token in our format.
+	 */
+	int split_on_whitespace;
+
+	/*
+	 * After a mark_query run, this object_info is set up to be
+	 * passed to sha1_object_info_extended. It will point to the data
+	 * elements above, so you can retrieve the response from there.
+	 */
+	struct object_info info;
+
+	/*
+	 * This flag will be true if the requested batch format and options
+	 * don't require us to call sha1_object_info, which can then be
+	 * optimized out.
+	 */
+	unsigned skip_object_info : 1;
+};
+
 struct ref_format {
 	/*
 	 * Set these to define the format; make sure you call

--
https://github.com/git/git/pull/450
Previous: Olga TelezhnayaNext: Jeff King
Message 19 of 47 in “cat-file: split expand_atom into 2 functions”
  1. 01/18 cat-file: split expand_atom into 2 functionsOlga Telezhnaya, Jan 10, 2018
  2. 14/18 ref-filter: get rid of expand_atom_into_fieldsOlga Telezhnaya, Jan 10, 2018
  3. 15/18 ref-filter: add is_cat flagOlga Telezhnaya, Jan 10, 2018
  4. 16/18 ref_format: add split_on_whitespace flagOlga Telezhnaya, Jan 10, 2018
  5. 08/18 ref-filter: get rid of gotoOlga Telezhnaya, Jan 10, 2018
  6. 18/18 ref-filter: make cat_file_info independentOlga Telezhnaya, Jan 10, 2018
  7. 02/18 cat-file: reuse struct ref_formatOlga Telezhnaya, Jan 10, 2018
  8. Jeff KingJan 15, 2018
  9. Оля ТележнаяJan 16, 2018
  10. 07/18 cat-file: remove unused codeOlga Telezhnaya, Jan 10, 2018
  11. 10/18 cat-file: get rid of duplicate checkingOlga Telezhnaya, Jan 10, 2018
  12. 17/18 cat-file: move skip_object_info into ref-filterOlga Telezhnaya, Jan 10, 2018
  13. 05/18 cat-file: start migrating to ref-filterOlga Telezhnaya, Jan 10, 2018
  14. 09/18 cat-file: simplify expand_atom functionOlga Telezhnaya, Jan 10, 2018
  15. 13/18 cat-file: start reusing populate_valueOlga Telezhnaya, Jan 10, 2018
  16. 11/18 cat-file: start use ref_array_item structOlga Telezhnaya, Jan 10, 2018
  17. 06/18 ref-filter: reuse parse_ref_filter_atomOlga Telezhnaya, Jan 10, 2018
  18. 12/18 ref-filter: make populate_value globalOlga Telezhnaya, Jan 10, 2018
  19. 04/18 cat-file: move struct expand_data into ref-filterOlga Telezhnaya, Jan 10, 2018
  20. Jeff KingJan 15, 2018
  21. Оля ТележнаяJan 16, 2018
  22. Jeff KingJan 17, 2018
  23. Оля ТележнаяJan 18, 2018
  24. 03/18 ref-filter: make valid_atom as function parameterOlga Telezhnaya, Jan 10, 2018
  25. Jeff KingJan 15, 2018
  26. Оля ТележнаяJan 16, 2018
  27. Jeff KingJan 17, 2018
  28. Christian CouderJan 17, 2018
  29. Оля ТележнаяJan 18, 2018
  30. Оля ТележнаяJan 18, 2018
  31. Christian CouderJan 18, 2018
  32. Оля ТележнаяJan 19, 2018
  33. Christian CouderJan 19, 2018
  34. Christian CouderJan 19, 2018
  35. Оля ТележнаяJan 19, 2018
  36. Christian CouderJan 19, 2018
  37. Jeff KingJan 19, 2018
  38. Christian CouderJan 19, 2018
  39. Junio C HamanoJan 19, 2018
  40. Jeff KingJan 19, 2018
  41. Jeff KingJan 15, 2018
  42. Jeff KingJan 15, 2018
  43. Оля ТележнаяJan 16, 2018
  44. Jeff KingJan 17, 2018
  45. Christian CouderJan 17, 2018
  46. Оля ТележнаяJan 18, 2018
  47. Christian CouderJan 18, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.