git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] packfile: use get_be64() for large offsets

From
Jeff King <peff@peff.net>
Date
Jan 17, 2018, 22:29 UTC
Message-ID
<20180117222953.GB16031@sigill.intra.peff.net>
In-Reply-To
<20180117190823.209469-1-dstolee@microsoft.com>
On Wed, Jan 17, 2018 at 02:08:23PM -0500, Derrick Stolee wrote:
> The pack-index version 2 format uses two 4-byte integers in network-byte order to represent one 8-byte value. The current implementation has several code clones for stitching these integers together.

Yeah, this seems like a no-brainer, and the patch itself looks obviously correct.

Please wrap your commit messages a bit shorter, though (say, between 60-72 chars).

-Peff
Previous: Derrick StoleeNext: Derrick Stolee
Message 2 of 5 in “packfile: use get_be64() for large offsets”
  1. packfile: use get_be64() for large offsetsDerrick Stolee, Jan 17, 2018
  2. Jeff KingJan 17, 2018
  3. packfile: use get_be64() for large offsetsDerrick Stolee, Jan 18, 2018
  4. SZEDER GáborJan 18, 2018
  5. Junio C HamanoJan 19, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.