From: Jeff King Date: Wed, 17 Jan 2018 22:29:53 GMT Subject: Re: [PATCH] packfile: use get_be64() for large offsets Message-ID: <20180117222953.GB16031@sigill.intra.peff.net> In-Reply-To: <20180117190823.209469-1-dstolee@microsoft.com> On Wed, Jan 17, 2018 at 02:08:23PM -0500, Derrick Stolee wrote: > The pack-index version 2 format uses two 4-byte integers in network-byte order to represent one 8-byte value. The current implementation has several code clones for stitching these integers together. Yeah, this seems like a no-brainer, and the patch itself looks obviously correct. Please wrap your commit messages a bit shorter, though (say, between 60-72 chars). -Peff