Re: [PATCH 4/4] clone: do not clean up directories we didn't create
- From
Jeff King <peff@peff.net>
- Date
- Jan 2, 2018, 23:39 UTC
- Message-ID
- <20180102233932.GA27884@sigill.intra.peff.net>
- In-Reply-To
- <CAPig+cQOU7d21kDELtFAkM0qJh8pvj7F56oWVYw+kYiUftQEuA@mail.gmail.com>
On Tue, Jan 02, 2018 at 05:49:45PM -0500, Eric Sunshine wrote:
Show 19 quoted lines
> > diff --git a/t/t5600-clone-fail-cleanup.sh b/t/t5600-clone-fail-cleanup.sh > > @@ -42,13 +53,48 @@ test_expect_success 'successful clone must leave the directory' ' > > +test_expect_success 'failed clone into empty leaves directory (separate, git)' ' > > + mkdir -p empty-git && > > + corrupt_repo && > > + test_must_fail git clone --separate-git-dir empty-git foo no-wt && > > + test_dir_is_empty empty-git && > > + test_path_is_missing no-wt > > +' > > + > > +test_expect_success 'failed clone into empty leaves directory (separate, git)' ' > > + mkdir -p empty-wt && > > + corrupt_repo && > > + test_must_fail git clone --separate-git-dir no-git foo empty-wt && > > + test_path_is_missing no-git && > > + test_dir_is_empty empty-wt > > +' > > The final two tests seem to have the same title...
Oops. The second one should be "wt" (since the idea was to flip the logic from the previous). Like so:
diff --git a/t/t5600-clone-fail-cleanup.sh b/t/t5600-clone-fail-cleanup.sh index 5cd94d5558..4a1a912e03 100755 --- a/t/t5600-clone-fail-cleanup.sh +++ b/t/t5600-clone-fail-cleanup.sh @@ -89,7 +89,7 @@ test_expect_success 'failed clone into empty leaves directory (separate, git)' ' test_path_is_missing no-wt ' -test_expect_success 'failed clone into empty leaves directory (separate, git)' ' +test_expect_success 'failed clone into empty leaves directory (separate, wt)' ' mkdir -p empty-wt && corrupt_repo && test_must_fail git clone --separate-git-dir no-git foo empty-wt &&