Re: [PATCH] Add shell completion for git remote rm

From: Todd Zullinger <tmz@pobox.com>
Date: Dec 29, 2017, 13:52 UTC
Message-ID: <20171229135240.GQ3693@zaya.teonanacatl.net>
In-Reply-To: <20171229041927.GA83931@bryant.local>

Keith Smiley wrote:

> It looks like that was just about preferring remove in documentation
> and the like, I think it would still make sense to have both for
> completion since rm is still supported.

I read it as a first step in a long process to eventually remove 'remote rm', but if that's never intended, then sure, restoring completion for it seems reasonable.

It would be good to hear from those who know or recall the intention.

I think we should only complete the preferred subcommand. That encourages use of 'remote remove' even if 'remote rm' will stay forever to avoid breaking existing scripts.

If it does make sense to restore completion, adding a link back to e17dba8fe1 and explaining why the completion is being restored would be good. Reading the commit message now makes it sound like 'remote rm' was never present and is being added to correct an oversight.

Maybe something like:

    completion: restore 'remote rm'

    e17dba8fe1 ("remote: prefer subcommand name 'remove' to
    'rm'", 2012-09-06) removed the 'rm' subcommand from
    completion.  The 'remote rm' subcommand is still supported
    and not planned to be removed.  Offer completions for it.

I also noticed that in your original commit that you say "list of removes as remove does." That should be "remotes" instead of "removes" there. -- I've made that typo myself quite often. :)

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
There are no stupid questions, but there are a LOT of inquisitive
idiots.
    -- Demotivators (www.despair.com)