Re: [PATCH] Add shell completion for git remote rm
- From
- Keith Smiley <k@keith.so>
- Date
- Dec 29, 2017, 06:21 UTC
- Message-ID
- <20171229062103.GA19203@bryant.local>
- In-Reply-To
- <20171229060016.GA25718@alpha.vpn.ikke.info>
Sorry about that! Patch below.
Previously git remote rm did not complete your list of removes as remove does.
Signed-off-by: Keith Smiley <k@keith.so> --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 3683c772c5586..3e9044087e6ba 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -2665,7 +2665,7 @@ _git_config () _git_remote () { local subcommands=" - add rename remove set-head set-branches + add rename remove rm set-head set-branches get-url set-url show prune update " local subcommand="$(__git_find_on_cmdline "$subcommands")" -- Keith Smiley On 12/29, Kevin Daudt wrote: >On Fri, Dec 29, 2017 at 02:01:00AM +0000, Keith Smiley wrote: >> From: Keith Smiley <keithbsmiley@gmail.com> >> >> Previously git remote rm did not complete your list of removes as remove >> does. > >Your signed-off-by[1] is missing, could you please add that? > >[1]: >https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L278 > >> --- >> contrib/completion/git-completion.bash | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash >> index 3683c772c5586..3e9044087e6ba 100644 >> --- a/contrib/completion/git-completion.bash >> +++ b/contrib/completion/git-completion.bash >> @@ -2665,7 +2665,7 @@ _git_config () >> _git_remote () >> { >> local subcommands=" >> - add rename remove set-head set-branches >> + add rename remove rm set-head set-branches >> get-url set-url show prune update >> " >> local subcommand="$(__git_find_on_cmdline "$subcommands")" >> >> -- >> https://github.com/git/git/pull/448