Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 1, 2017, 03:53 UTC
Message-ID: <20171201035340.GJ20640@aiede.mtv.corp.google.com>
In-Reply-To: <20171201034519.GE3693@zaya.teonanacatl.net>

Todd Zullinger wrote:

Show 17 quoted lines

> Much better, thank you.  How about this for the full commit message:
>
>    t/lib-git-svn.sh: improve svnserve tests with parallel make test
>
>    Setting SVNSERVE_PORT enables several tests which require a local
>    svnserve daemon to be run (in t9113 & t9126).  The tests share setup of
>    the local svnserve via `start_svnserve()`.  The function uses svnserve's
>    `--listen-once` option, which causes svnserve to accept one connection
>    on the port, serve it, and exit.  When running the tests in parallel
>    this fails if one test tries to start svnserve while the other is still
>    running.
>
>    Use the test number as the svnserve port (similar to httpd tests) to
>    avoid port conflicts.  Developers can set GIT_TEST_SVNSERVE to any value
>    other than 'false' or 'auto' to enable these tests.
>
> ?

Yep, with this description it is
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks for putting up with my nits. :)

Jonathan