Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test

From: Todd Zullinger <tmz@pobox.com>
Date: Dec 1, 2017, 03:45 UTC
Message-ID: <20171201034519.GE3693@zaya.teonanacatl.net>
In-Reply-To: <20171201030234.GF20640@aiede.mtv.corp.google.com>

Hi Jonathan,

Jonathan Nieder wrote:

Show 17 quoted lines

> Todd Zullinger wrote:
>
>> Previously, setting SVNSERVE_PORT enabled several tests which require a
>> local svnserve daemon to be run (in t9113 & t9126).  The tests share the
>> setup of the local svnserve via `start_svnserve()`.  The function uses
>> the svnserve option `--listen-once` which causes svnserve to accept one
>> connection on the port, serve it, and exit.  When running the tests in
>> parallel this fails if one test tries to start svnserve while the other
>> is still running.
>
> I had trouble reading this because I didn't know what previous time it
> was referring to.  Is it about how the option currently behaves?
>
> (Git's commit messages tend to use the present tense to describe the
> behavior before the patch, like a bug report, and the imperative to
> describe the change the patch proposes to make, like an impolite bug
> report. :))

This is what I get for skipping grammar classes to go hiking in my youth. But I'm sure I'd do it all again, if given the chance. ;)

Show 11 quoted lines

>> Use the test number as the svnserve port (similar to httpd tests) to
>> avoid port conflicts.  Set GIT_TEST_SVNSERVE to any value other than
>> 'false' or 'auto' to enable these tests.
>
> This uses imperative in two ways and also ended up confusing me.  The
> second one is a direction to me, not Git, right?  How about:
>
> 	Use the test number instead of $SVNSERVE_PORT as the svnserve
> 	port (similar to httpd tests) to avoid port conflicts.
> 	Developers can set GIT_TEST_SVNSERVE to any value other than
> 	'false' or 'auto' to enable these tests.

Much better, thank you.  How about this for the full commit message:

    t/lib-git-svn.sh: improve svnserve tests with parallel make test

    Setting SVNSERVE_PORT enables several tests which require a local
    svnserve daemon to be run (in t9113 & t9126).  The tests share setup of
    the local svnserve via `start_svnserve()`.  The function uses svnserve's
    `--listen-once` option, which causes svnserve to accept one connection
    on the port, serve it, and exit.  When running the tests in parallel
    this fails if one test tries to start svnserve while the other is still
    running.

    Use the test number as the svnserve port (similar to httpd tests) to
    avoid port conflicts.  Developers can set GIT_TEST_SVNSERVE to any value
    other than 'false' or 'auto' to enable these tests.

Thanks,

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Curiosity killed the cat, but for awhile I was a suspect.
    -- Steven Wright