Re: [PATCH] travis-ci: avoid new tcl/tk build requirement

From: Todd Zullinger <tmz@pobox.com>
Date: Nov 28, 2017, 16:02 UTC
Message-ID: <20171128160222.GO3693@zaya.teonanacatl.net>
In-Reply-To: <CAP8UFD1Y_7FcARFoqNKTpDLRxKW1+jCBGAy5+TxL33ui0Hyb8w@mail.gmail.com>

Christian Couder wrote:

Show 10 quoted lines

>> Junio C Hamano wrote:
>>> It seems that TravisCI objects ;-)
>>>
>>>    https://travis-ci.org/git/git/jobs/307745929
>>
>> Interesting that the main builds passed.  I don't know what the default
>> 64-bit linuxinstall looks like in travis, so I presume it includes
>> tcl/tk or something.
>
> Yeah, interesting. I am cc'ing Lars who perhaps knows.

I pulled the travis docker image used in clang/gcc builds[1] and can see it has both tcl and tk packages installed. The linux32 builds use a docker image[2] which does not contain tcl or tk.

[1] travisci/ci-garnet:packer-1503972846 [2] daald/ubuntu32:xenial

If we wanted, we could set BYPASS_TCLTK_CHECK only for the linux32 builds. I think it's probably better to do it globally rather than rely on the travis containers implicitly having tcl/tk installed.

> The patch looks good to me. Thanks!
>
> I wonder if it would be better to squash it into my patch or to keep
> it separate. I am ok with both ways.

I fine either way too. This is still just on pu, so squashing it in seems like the way to go. I only made it separate to cause travis to run the tests. :)

-- 
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In the beginning the Universe was created. This has made a lot of
people very angry and has been widely regarded as a bad move.
    -- Douglas Adams