Re: [PATCH] Makefile: check that tcl/tk is installed

From: Jeff King <peff@peff.net>
Date: Nov 27, 2017, 15:27 UTC
Message-ID: <20171127152748.GA23218@sigill.intra.peff.net>
In-Reply-To: <CAP8UFD2tB_CpopP5OuqPSBfeeGzXfoC_Hz-UeT=eNW1fU6zyzA@mail.gmail.com>

On Mon, Nov 27, 2017 at 09:24:47AM +0100, Christian Couder wrote:

Show 9 quoted lines

> > Yeah, this side-steps the "other half" of the issue that Christian's
> > patch addresses, which seems like the more controversial part (I don't
> > have a strong opinion myself, though).
> 
> I don't think any part of my patch should be controversial. I
> repeatedly wrote very long messages to show all the possible cases, so
> that it is easy to see that we are not worse in any case. And all the
> competing suggestions, even the above from Junio either have
> significant problems or address a different problem.

Sorry, controversial may not have been the right word. It's just that the review discussion focused around packagers who may want to build git without having "wish" on the build machine. If everybody is happy with the BYPASS mechanism you added to address that, then I'm perfectly fine with it.

-Peff