Re: [PATCH v3 00/33] Add directory rename detection to git

From: Adam Dinwoodie <adam@dinwoodie.org>
Date: Nov 23, 2017, 11:52 UTC
Message-ID: <20171123115246.GV20681@dinwoodie.org>
In-Reply-To: <20171121080059.32304-1-newren@gmail.com>

On Tuesday 21 November 2017 at 12:00 am -0800, Elijah Newren wrote:

Show 11 quoted lines

> <snip>
> 
>  merge-recursive.c                   | 1243 +++++++++++-
>  merge-recursive.h                   |   17 +
>  t/t3501-revert-cherry-pick.sh       |    5 +-
>  t/t6043-merge-rename-directories.sh | 3821 +++++++++++++++++++++++++++++++++++
>  t/t7607-merge-overwrite.sh          |    7 +-
>  unpack-trees.c                      |    4 +-
>  unpack-trees.h                      |    4 +
>  7 files changed, 4985 insertions(+), 116 deletions(-)
>  create mode 100755 t/t6043-merge-rename-directories.sh

The new t6043.44 introduced in this branch is failing on my Cygwin system. I can't immeditely see what's causing the failure, but I've copied the relevant verbose + shell tracing output below in the hope it makes more sense to you:

expecting success:
        (
                cd 7b &&

                git checkout A^0 &&

                test_must_fail git merge -s recursive B^0 >out &&
                test_i18ngrep "CONFLICT (rename/rename)" out &&

                test 4 -eq $(git ls-files -s | wc -l) &&
                test 2 -eq $(git ls-files -u | wc -l) &&
                test 3 -eq $(git ls-files -o | wc -l) &&

                git rev-parse >actual \
                        :0:y/b :0:y/c :2:y/d :3:y/d &&
                git rev-parse >expect \
                        O:z/b O:z/c O:w/d O:x/d &&
                test_cmp expect actual &&

                test ! -f y/d &&
                test -f y/d~HEAD &&
                test -f y/d~B^0 &&

                git hash-object >actual \
                        y/d~HEAD y/d~B^0 &&
                git rev-parse >expect \
                        O:w/d O:x/d &&
                test_cmp expect actual
        )

++ cd 7b
++ git checkout 'A^0'
Note: checking out 'A^0'.

You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD is now at 0808992 A
++ test_must_fail git merge -s recursive 'B^0'
++ case "$1" in
++ _test_ok=
++ git merge -s recursive 'B^0'
++ exit_code=1
++ test 1 -eq 0
++ test_match_signal 13 1
++ test 1 = 141
++ test 1 = 269
++ return 1
++ test 1 -gt 129
++ test 1 -eq 127
++ test 1 -eq 126
++ return 0
++ test_i18ngrep 'CONFLICT (rename/rename)' out
++ test -n ''
++ test 'x!' = 'xCONFLICT (rename/rename)'
++ grep 'CONFLICT (rename/rename)' out
CONFLICT (rename/rename): Rename w/d->y/d in HEAD. Rename x/d->y/d in B^0
+++ git ls-files -s
+++ wc -l
++ test 4 -eq 4
+++ git ls-files -u
+++ wc -l
++ test 2 -eq 2
+++ git ls-files -o
+++ wc -l
++ test 3 -eq 3
++ git rev-parse :0:y/b :0:y/c :2:y/d :3:y/d
++ git rev-parse O:z/b O:z/c O:w/d O:x/d
++ test_cmp expect actual
++ diff -u expect actual
++ test '!' -f y/d
+ test_eval_ret_=1
+ want_trace
+ test t = t
+ test t = t
+ set +x
error: last command exited with $?=1
not ok 44 - 7b-check: rename/rename(2to1), but only due to transitive rename