git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t1404: add a bunch of tests of D/F conflicts

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Oct 29, 2017, 16:12 UTC
Message-ID
<20171029161206.soieyxfiru2fvi7j@genre.crustytoothpaste.net>
In-Reply-To
<xmqqk1zebyxz.fsf@gitster.mtv.corp.google.com>
On Sun, Oct 29, 2017 at 09:05:44AM +0900, Junio C Hamano wrote:
> In short, unless you are a binary packager on a platform whose
> native shell is ksh and who refuses to depend on tools that are not
> default/native on the platform, you'd be OK?
Yes.
Show 10 quoted lines
> > I'd recommend an explicit test for this.  It's much easier to track down
> > that way than seeing other failure scenarios.  People will also usually
> > complain about failing tests.
> 
> Hopefully.
> 
> Starting from an explicit test, gradually using more "local" in
> tests that cover more important parts of the system, and then start
> using "local" as appropriate in the main tools would be a good way
> forward.

I completely agree. I just wanted to ensure that if we failed, it was at least obvious to packagers who ran the tests. I'm not sure there's anything we can do if people don't run them.

I do think people may run the tests more frequently than you think, though. I always do in my packaging at $DAYJOB, but any failures (usually missing SANITY) tend to already be patched by the time I get off work and write a patch.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
Previous: Junio C HamanoNext: Michael Haggerty
Message 10 of 14 in “Fix an error-handling path when locking refs”
  1. 0/2 Fix an error-handling path when locking refsMichael Haggerty, Oct 24, 2017
  2. 1/2 t1404: add a bunch of tests of D/F conflictsMichael Haggerty, Oct 24, 2017
  3. Eric SunshineOct 24, 2017
  4. Jeff KingOct 24, 2017
  5. Michael HaggertyOct 25, 2017
  6. Michael HaggertyOct 25, 2017
  7. Jeff KingOct 26, 2017
  8. brian m. carlsonOct 28, 2017
  9. Junio C HamanoOct 29, 2017
  10. brian m. carlsonOct 29, 2017
  11. 2/2 files_transaction_prepare(): fix handling of ref lock failureMichael Haggerty, Oct 24, 2017
  12. Jeff KingOct 24, 2017
  13. Junio C HamanoOct 25, 2017
  14. Jeff KingOct 24, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.