Re: [PATCH 2/2] files_transaction_prepare(): fix handling of ref lock failure

From: Jeff King <peff@peff.net>
Date: Oct 24, 2017, 19:49 UTC
Message-ID: <20171024194921.mnrx3sxsd3w3pe3v@sigill.intra.peff.net>
In-Reply-To: <6214107e1232a7fe7ca4b7440733ff496f07e537.1508856679.git.mhagger@alum.mit.edu>

On Tue, Oct 24, 2017 at 05:16:25PM +0200, Michael Haggerty wrote:

> The fix is simple: instead of just breaking out of the loop, jump
> directly to the cleanup code. This fixes some tests in t1404 that were
> added in the previous commit.

Nicely explained.

I think that fix makes sense, and matches how the rest of the function behaved. The other option would be to switch the recently-added code to:

  if (!ret && packed_transaction)
     ...

but it seems like the "goto" means one less thing for new code to remember if it gets added.

-Peff