Re: [PATCH 0/3] making test-suite tracing more useful

From: Jeff King <peff@peff.net>
Date: Oct 24, 2017, 01:32 UTC
Message-ID: <20171024013234.ogma2sf37c7hfpib@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.2.21.1.1710231302480.6482@virtualbox>

On Mon, Oct 23, 2017 at 01:04:45PM +0200, Johannes Schindelin wrote:

Show 10 quoted lines

> > Johannes, I've seen that you do "-x" in the tests that the
> > git-for-windows bot uses to comment on GitHub. You may have seen the
> > bogus failure in t5615, which this series should fix (you may also have
> > seen the "set +x" cruft at the end of each test, which is fixed here,
> > too).
> 
> Surprisingly enough, I did not see any test failure in that test. I do
> re-run failed tests after the complete test run to make sure that the
> failure is not due to any resource scarcity, and that re-run is performed
> with -x (to double as documentation what really went wrong).

Ah, OK, that explains it. If t5615 never failed in the non-x run, then you wouldn't have run into it. So it was waiting to bite you, but that test script is simple enough that it never failed. :)

-Peff