Re: [PATCH 2/3] t5615: avoid re-using descriptor 4

From: Jeff King <peff@peff.net>
Date: Oct 20, 2017, 22:46 UTC
Message-ID: <20171020224608.3ataitvdq5r33iih@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kaSu+nHHntFPWbkXk1TC4ys9htesRg9HHXcpK+Y6MwZeg@mail.gmail.com>

On Fri, Oct 20, 2017 at 02:27:40PM -0700, Stefan Beller wrote:

> > So I dunno. It does solve the problem in a way that the individual test
> > scripts wouldn't have to care about. But it's a lot of eval trickery.
> 
> I agree. Maybe just stick with the original patch?

OK. Why don't we live with that for now, then. The only advantage of the "999" trickery is that it's less likely to come up again. If it doesn't, then we're happy. If it does, then we can always switch then.

I also noticed that our GIT_TRACE=4 trickery has the same problem (it didn't trigger in the t5615 case because it doesn't actually run git inside the subshell). If we end up doing a "999" descriptor eventually, we should probably point GIT_TRACE at it, too.

-Peff