Re: git repack leaks disk space on ENOSPC
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Oct 12, 2017, 11:01 UTC
- Message-ID
- <20171012110158.pxjn6ckgw6z2g3md@genre.crustytoothpaste.net>
- In-Reply-To
- <20171012093439.GD32090@inner.h.apk.li>
On Thu, Oct 12, 2017 at 11:34:39AM +0200, Andreas Krey wrote:
Show 10 quoted lines
> On Wed, 11 Oct 2017 20:17:03 +0000, Jonathan Nieder wrote: > > Does using create_tempfile there seem like a good path forward to you? > > Would you be interested in working on it (either writing a patch with > > such a fix or a test in t/ to make sure it keeps working)? > > I will look into creating a patch (thanks for the pointers), > but I don't see how to make a testcase for this - pre-filling the > disk doesn't sound like a good idea. Most people probably won't run in > this situation, and then won't have tmp_packs with a dozen GBytes each > lying around.
A patch would be very welcome. We have this problem not infrequently at work with development and test VMs, which tend to have a relatively small amount of disk.
If you decide that you don't want to create a patch, I'll probably pick it up eventually.
-- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204