Re: git repack leaks disk space on ENOSPC

From: Andreas Krey <a.krey@gmx.de>
Date: Oct 12, 2017, 09:34 UTC
Message-ID: <20171012093439.GD32090@inner.h.apk.li>
In-Reply-To: <20171012031702.GB155740@aiede.mtv.corp.google.com>

On Wed, 11 Oct 2017 20:17:03 +0000, Jonathan Nieder wrote:

Show 8 quoted lines

> Hi Andreas,
> 
> Andreas Krey wrote:
> 
> > I observed (again) an annoying behavior of 'git repack':
> 
> Do you have context for this 'again'?  E.g. was this discussed
> previously on-list?

I think I posted about it, but no discussion. I poked a bit at the code, with not much luck back then.

...

> Does using create_tempfile there seem like a good path forward to you?
> Would you be interested in working on it (either writing a patch with
> such a fix or a test in t/ to make sure it keeps working)?

I will look into creating a patch (thanks for the pointers), but I don't see how to make a testcase for this - pre-filling the disk doesn't sound like a good idea. Most people probably won't run in this situation, and then won't have tmp_packs with a dozen GBytes each lying around.

Andreas

-- 
"Totally trivial. Famous last words."
From: Linus Torvalds <torvalds@*.org>
Date: Fri, 22 Jan 2010 07:29:21 -0800