git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t9010-*.sh: skip all tests if the PIPE prereq is missing

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Sep 19, 2017, 02:52 UTC
Message-ID
<20170919025251.GF175206@aiede.mtv.corp.google.com>
In-Reply-To
<ffcf72e9-b724-3312-ca63-c21d0b8a235c@ramsayjones.plus.com>
Ramsay Jones wrote:
Show 12 quoted lines
> Every test in this file, except one, is marked with the PIPE prereq.
> However, that lone test ('set up svn repo'), only performs some setup
> work and checks whether the following test should be executed (by
> setting an additional SVNREPO prerequisite). Since the following test
> also requires the PIPE prerequisite, performing the setup test, when the
> PIPE preequisite is missing, is simply wasted effort. Use the skip-all
> test facility to skip all tests when the PIPE prerequisite is missing.
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  t/t9010-svn-fe.sh | 55 ++++++++++++++++++++++++++++---------------------------
>  1 file changed, 28 insertions(+), 27 deletions(-)

It was always the intention that this test script eventually be able to run on Windows, but it was not meant to be. It would need to use a socket or something for backflow to work on Windows.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Ramsay Jones
Message 2 of 2 in “t9010-*.sh: skip all tests if the PIPE prereq is missing”
  1. 2/2 t9010-*.sh: skip all tests if the PIPE prereq is missingRamsay Jones, Sep 17, 2017
  2. Jonathan NiederSep 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.