From: Jonathan Nieder Date: Tue, 19 Sep 2017 02:52:51 GMT Subject: Re: [PATCH 2/2] t9010-*.sh: skip all tests if the PIPE prereq is missing Message-ID: <20170919025251.GF175206@aiede.mtv.corp.google.com> In-Reply-To: Ramsay Jones wrote: > Every test in this file, except one, is marked with the PIPE prereq. > However, that lone test ('set up svn repo'), only performs some setup > work and checks whether the following test should be executed (by > setting an additional SVNREPO prerequisite). Since the following test > also requires the PIPE prerequisite, performing the setup test, when the > PIPE preequisite is missing, is simply wasted effort. Use the skip-all > test facility to skip all tests when the PIPE prerequisite is missing. > > Signed-off-by: Ramsay Jones > --- > t/t9010-svn-fe.sh | 55 ++++++++++++++++++++++++++++--------------------------- > 1 file changed, 28 insertions(+), 27 deletions(-) It was always the intention that this test script eventually be able to run on Windows, but it was not meant to be. It would need to use a socket or something for backflow to work on Windows. Reviewed-by: Jonathan Nieder