Re: [PATCH] protocol: make parse_protocol_version() private
On 09/17, Ramsay Jones wrote:
Show 12 quoted lines
>
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Brandon,
>
> If you need to re-roll your 'bw/protocol-v1' branch, could you please
> squash this into the relevant patch (commit 45954f179e, "protocol:
> introduce protocol extention mechanisms", 13-09-2017).
>
> This assumes you agree that this symbol does not need to be public; if
> not, then please just ignore! ;-)
Thanks! I've updated my local version of the series to reflect this.
Show 37 quoted lines
>
> Thanks!
>
> ATB,
> Ramsay Jones
>
> protocol.c | 2 +-
> protocol.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/protocol.c b/protocol.c
> index 1b16c7b9a..369503065 100644
> --- a/protocol.c
> +++ b/protocol.c
> @@ -2,7 +2,7 @@
> #include "config.h"
> #include "protocol.h"
>
> -enum protocol_version parse_protocol_version(const char *value)
> +static enum protocol_version parse_protocol_version(const char *value)
> {
> if (!strcmp(value, "0"))
> return protocol_v0;
> diff --git a/protocol.h b/protocol.h
> index 2fa6486d0..18f9a5235 100644
> --- a/protocol.h
> +++ b/protocol.h
> @@ -7,7 +7,6 @@ enum protocol_version {
> protocol_v1 = 1,
> };
>
> -extern enum protocol_version parse_protocol_version(const char *value);
> extern enum protocol_version get_protocol_version_config(void);
> extern enum protocol_version determine_protocol_version_server(void);
> extern enum protocol_version determine_protocol_version_client(const char *server_response);
> --
> 2.14.0--
Brandon Williams