git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] protocol: make parse_protocol_version() private

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Sep 17, 2017, 16:53 UTC
Message-ID
<1cb7d40d-3f11-71a0-6e53-dced7810a0ca@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Brandon,

If you need to re-roll your 'bw/protocol-v1' branch, could you please squash this into the relevant patch (commit 45954f179e, "protocol: introduce protocol extention mechanisms", 13-09-2017).

This assumes you agree that this symbol does not need to be public; if not, then please just ignore! ;-)

Thanks!

ATB, Ramsay Jones

 protocol.c | 2 +-
 protocol.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/protocol.c b/protocol.c
index 1b16c7b9a..369503065 100644
--- a/protocol.c
+++ b/protocol.c
@@ -2,7 +2,7 @@
 #include "config.h"
 #include "protocol.h"
 
-enum protocol_version parse_protocol_version(const char *value)
+static enum protocol_version parse_protocol_version(const char *value)
 {
 	if (!strcmp(value, "0"))
 		return protocol_v0;
diff --git a/protocol.h b/protocol.h
index 2fa6486d0..18f9a5235 100644
--- a/protocol.h
+++ b/protocol.h
@@ -7,7 +7,6 @@ enum protocol_version {
 	protocol_v1 = 1,
 };
 
-extern enum protocol_version parse_protocol_version(const char *value);
 extern enum protocol_version get_protocol_version_config(void);
 extern enum protocol_version determine_protocol_version_server(void);
 extern enum protocol_version determine_protocol_version_client(const char *server_response);
-- 
2.14.0
Next: Brandon Williams
Message 1 of 2 in “protocol: make parse_protocol_version() private”
  1. protocol: make parse_protocol_version() privateRamsay Jones, Sep 17, 2017
  2. Brandon WilliamsSep 18, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.