Re: [PATCH 0/3] merge-base --fork-point fixes

From: Jeff King <peff@peff.net>
Date: Sep 14, 2017, 14:38 UTC
Message-ID: <20170914143839.l5u7qof6xgwsojbd@sigill.intra.peff.net>
In-Reply-To: <cover.1505394278.git.git@grubix.eu>

On Thu, Sep 14, 2017 at 03:15:17PM +0200, Michael J Gruber wrote:

Show 8 quoted lines

> merge-base --fork-point does not quite work as advertised when the
> reflog is empty or partial. This series brings it in line with the
> documentation and, hopefully, with the original intent.
> 
> Michael J Gruber (3):
>   t6010: test actual test output
>   merge-base: return fork-point outside reflog
>   merge-base: find fork-point outside partial reflog

Patches 1 and 3 look sane to me. Your argument in patch 2 looks plausible to me, but I'm not familiar enough with the mechanics of fork-point to have a solid opinion.

-Peff