Re: [PATCH 1/3] t6010: test actual test output

From: Michael J Gruber <git@grubix.eu>
Date: Sep 15, 2017, 10:01 UTC
Message-ID: <089cdbf6-7556-6fba-21f2-6602c5ca8920@grubix.eu>
In-Reply-To: <20170914143450.tmomqf2vs55tk3nz@sigill.intra.peff.net>

Jeff King venit, vidit, dixit 14.09.2017 16:34:

Show 13 quoted lines

> On Thu, Sep 14, 2017 at 03:15:18PM +0200, Michael J Gruber wrote:
> 
>> 4f21454b55 ("merge-base: handle --fork-point without reflog",
>> 2016-10-12) introduced a fix for merge-base --fork-point without reflog
>> and a test. While that test is fine, it did not update expected nor actual
>> output and tested that of the previous test instead.
> 
> Oops. The use of the existing "expect3" was intentional (the idea being
> that we are repeating the identical step from the previous test with the
> slight tweak of not having a reflog). But obviously failing to write to
> "actual" at all was a mistake.
> 
> That said, I'm OK with reiterating the expected output.

expect3 had a different content, too ;)

Michael