git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] usage: conditionally compile unleak_memory() definition

From
Jeff King <peff@peff.net>
Date
Sep 8, 2017, 03:37 UTC
Message-ID
<20170908033733.r3c2akrtbk5wvqad@sigill.intra.peff.net>
In-Reply-To
<1cf112f5-aad1-e1c6-b507-9524f4b72fec@ramsayjones.plus.com>
On Thu, Sep 07, 2017 at 05:08:23PM +0100, Ramsay Jones wrote:
Show 11 quoted lines
> Hi Jeff,
> 
> If you need to re-roll your 'jk/leak-checkers' branch, could you
> please squash this into the relevant patch (commit c57586d954,
> "add UNLEAK annotation for reducing leak false positives", 05-09-2017).
> 
> This was noticed by sparse, since it is not declared when the
> SUPPRESS_ANNOTATED_LEAKS pre-processor macro is not defined.
> (You could move the declaration out of the #ifdef in the header
> file, I suppose, but it seems pointless to compile the function
> if it isn't being used).

Thanks, that makes sense. There are a handful of other bits to modify in that final commit, so I will end up with at least one re-roll.

-Peff
Previous: Ramsay Jones
Message 2 of 2 in “usage: conditionally compile unleak_memory() definition”
  1. usage: conditionally compile unleak_memory() definitionRamsay Jones, Sep 7, 2017
  2. Jeff KingSep 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.