From: Jeff King <peff@peff.net>
Date: Fri, 08 Sep 2017 03:37:34 GMT
Subject: Re: [PATCH] usage: conditionally compile unleak_memory() definition
Message-ID: <20170908033733.r3c2akrtbk5wvqad@sigill.intra.peff.net>
In-Reply-To: <1cf112f5-aad1-e1c6-b507-9524f4b72fec@ramsayjones.plus.com>

On Thu, Sep 07, 2017 at 05:08:23PM +0100, Ramsay Jones wrote:

> Hi Jeff,
> 
> If you need to re-roll your 'jk/leak-checkers' branch, could you
> please squash this into the relevant patch (commit c57586d954,
> "add UNLEAK annotation for reducing leak false positives", 05-09-2017).
> 
> This was noticed by sparse, since it is not declared when the
> SUPPRESS_ANNOTATED_LEAKS pre-processor macro is not defined.
> (You could move the declaration out of the #ifdef in the header
> file, I suppose, but it seems pointless to compile the function
> if it isn't being used).

Thanks, that makes sense. There are a handful of other bits to modify in
that final commit, so I will end up with at least one re-roll.

-Peff