Re: What's cooking in git.git (Aug 2017, #04; Fri, 18)

From: Jeff King <peff@peff.net>
Date: Aug 20, 2017, 09:29 UTC
Message-ID: <20170820092937.7u3wshb44bai6kka@sigill.intra.peff.net>
In-Reply-To: <xmqq60dkbma1.fsf@gitster.mtv.corp.google.com>

On Fri, Aug 18, 2017 at 02:26:14PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> * jk/drop-ancient-curl (2017-08-09) 5 commits
>  - http: #error on too-old curl
>  - curl: remove ifdef'd code never used with curl >=7.19.4
>  - http: drop support for curl < 7.19.4
>  - http: drop support for curl < 7.16.0
>  - http: drop support for curl < 7.11.1
> 
>  Some code in http.c that has bitrot is being removed.
> 
>  What is the status of the discussion around this area????

This definitely should not be merged to 'next'; there were a few minor issues people pointed out. I haven't re-rolled because I was trying to figure out if we were interested in moving forward with this or not.

I'm still inclined in that direction, though I agree the information from Tom (and his series) does weaken my argument somewhat.

Show 11 quoted lines

> * tc/curl-with-backports (2017-08-11) 2 commits
>  - http: use a feature check to enable GSSAPI delegation control
>  - http: fix handling of missing CURLPROTO_*
> 
>  Updates to the HTTP layer we made recently unconditionally used
>  features of libCurl without checking the existence of them, causing
>  compilation errors, which has been fixed.  Also migrate the code to
>  check feature macros, not version numbers, to cope better with
>  libCurl that vendor ships with backported features.
> 
>  What is the doneness of this topic????

These look OK to me, and I just dropped a few comments in the thread.

-Peff