git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] tree-walk: convert fill_tree_descriptor() to object_id

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Aug 12, 2017, 14:59 UTC
Message-ID
<20170812145928.jadxm3digocyejzg@genre.crustytoothpaste.net>
In-Reply-To
<9534aa87-def3-5105-652d-f136c72902c2@web.de>
On Sat, Aug 12, 2017 at 10:32:59AM +0200, René Scharfe wrote:
Show 7 quoted lines
> All callers of fill_tree_descriptor() have been converted to object_id
> already, so convert that function as well.  As a nice side-effect we get
> rid of NULL checks in tree-diff.c, as fill_tree_descriptor() already
> does them for us.
> 
> Helped-by: Johannes Sixt <j6t@kdbg.org>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>

This looks good to me. I had written a very similar patch for a later series, and they're pretty much identical.

-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204
Previous: René Scharfe
Message 4 of 4 in “tree-walk: convert fill_tree_descriptor() to object_id”
  1. tree-walk: convert fill_tree_descriptor() to object_idRené Scharfe, Aug 12, 2017
  2. Johannes SixtAug 12, 2017
  3. tree-walk: convert fill_tree_descriptor() to object_idRené Scharfe, Aug 12, 2017
  4. brian m. carlsonAug 12, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.