From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Sat, 12 Aug 2017 14:59:28 GMT
Subject: Re: [PATCH v2] tree-walk: convert fill_tree_descriptor() to object_id
Message-ID: <20170812145928.jadxm3digocyejzg@genre.crustytoothpaste.net>
In-Reply-To: <9534aa87-def3-5105-652d-f136c72902c2@web.de>

On Sat, Aug 12, 2017 at 10:32:59AM +0200, René Scharfe wrote:
> All callers of fill_tree_descriptor() have been converted to object_id
> already, so convert that function as well.  As a nice side-effect we get
> rid of NULL checks in tree-diff.c, as fill_tree_descriptor() already
> does them for us.
> 
> Helped-by: Johannes Sixt <j6t@kdbg.org>
> Signed-off-by: Rene Scharfe <l.s.r@web.de>

This looks good to me.  I had written a very similar patch for a later
series, and they're pretty much identical.
-- 
brian m. carlson / brian with sandals: Houston, Texas, US
https://www.crustytoothpaste.net/~bmc | My opinion only
OpenPGP: https://keybase.io/bk2204