git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] imap-send: escape backslash in password

From
Jeff King <peff@peff.net>
Date
Aug 9, 2017, 12:04 UTC
Message-ID
<20170809120432.am77utnrnkh6mpgt@sigill.intra.peff.net>
In-Reply-To
<xmqqk22ec84i.fsf@gitster.mtv.corp.google.com>
On Tue, Aug 08, 2017 at 09:54:53AM -0700, Junio C Hamano wrote:
Show 24 quoted lines
> > For comparison, nothing older than curl 7.19.4 will work for building
> > Git since v2.12.0, as we added some unconditional uses of CURLPROTO_*
> > there. Nobody seems to have noticed or complained. I pointed this out a
> > few months ago[1] and suggested we clean up some of the more antiquated
> > #if blocks in http.c that don't even build. There was some complaint
> > that we should keep even these ancient versions working, but the
> > compile error is still in "master".
> >
> > So it's not clear to me that anybody cares about going that far back
> > (which is mid-2009), but I'd guess that 2013 might cause some problems.
> >
> > [1] https://public-inbox.org/git/20170404025438.bgxz5sfmrawqswcj@sigill.intra.peff.net/
> >     if you're curious (you were offline for a while at that time, I
> >     think).
> 
> Thanks for digging.  It would not help the issue on this thread at
> all.  While I agree with your conclusion in the quoted thread:
> 
>     I think it might be nice to declare a "too old" version, though,
>     just so we can stop adding _new_ ifdefs. Maybe 7.11.1 is that
>     version now, and in another few years we can bump to 7.16.0. :)
> 
> it appears that we silently declared it to 7.19.4 and found out that
> nobody complained, without us having to wait for a few years?

Yeah, I think the 7.19.4 breakage was discussed after I wrote that (and after investigating, I think the 7.16.0 cutoff is probably pretty reasonable even without that). I do think it's worth addressing. I just sent a series:

  https://public-inbox.org/git/20170809120024.7phdjzjv54uv5dpz@sigill.intra.peff.net/
-Peff
Previous: Junio C HamanoNext: brian m. carlson
Message 13 of 15 in “[RFC] imap-send: escape backslash in password”
  1. Nicolas Morey-ChaisemartinAug 4, 2017
  2. Junio C HamanoAug 4, 2017
  3. Nicolas Morey-ChaisemartinAug 4, 2017
  4. Andreas SchwabAug 4, 2017
  5. Jeff KingAug 4, 2017
  6. Junio C HamanoAug 4, 2017
  7. Jeff KingAug 4, 2017
  8. Nicolas Morey-ChaisemartinAug 6, 2017
  9. Jeff KingAug 7, 2017
  10. Junio C HamanoAug 7, 2017
  11. Jeff KingAug 8, 2017
  12. Junio C HamanoAug 8, 2017
  13. Jeff KingAug 9, 2017
  14. brian m. carlsonAug 4, 2017
  15. Jeff KingAug 4, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.