Re: [RFC] imap-send: escape backslash in password

From: Jeff King <peff@peff.net>
Date: Aug 4, 2017, 21:22 UTC
Message-ID: <20170804212231.pl3uipcsujflcuha@sigill.intra.peff.net>
In-Reply-To: <xmqq3797t4kq.fsf@gitster.mtv.corp.google.com>

On Fri, Aug 04, 2017 at 02:18:13PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> > I also think it might be reasonable to scrap all of this ad-hoc imap
> > code in favor of curl, which already gets these cases right. We already
> > have a curl-backed implementation. I think we just left the old code out
> > of conservatism. But it seems somewhat buggy and unmaintained, and I
> > wonder if we aren't better off to simply encourage people to install
> > curl.
> 
> That is a very attractive direction to go in, especially in the mid
> to longer term.  Perhaps we declare that the ad-hoc hardcoded imap
> is deprecated in the next cycle and drop the support by the end of
> this year?

That is fine by me. AFAIK, we already build the curl support by default when a sufficiently-advanced version of curl is available. So if there were feature-parity problems hopefully somebody would have reported it.

I think the deprecation here can be relatively fast because we're not actually dropping support for any feature. We're just requiring that they install curl to get the same functionality (which might be inconvenient, but it's a heck of a lot less inconvenient than "there's no way to do what you want anymore").

-Peff