Re: [PATCH 2/3] revision.c: use skip_prefix() in handle_revision_opt()
- From
Jeff King <peff@peff.net>
- Date
- Jun 10, 2017, 06:44 UTC
- Message-ID
- <20170610064426.ylzdx2v4ffdz2jkh@sigill.intra.peff.net>
- In-Reply-To
- <20170609181733.6793-1-szeder.dev@gmail.com>
On Fri, Jun 09, 2017 at 08:17:28PM +0200, SZEDER Gábor wrote:
Show 20 quoted lines
> So, here comes v2. The interdiff is below, the changes since v1 are:
>
> - Patch 1/5 is new to fix a more fundamental problem with
> '--early-output'.
> - Patch 3/5 is new to fix this '--early-output-foo' issue and also
> to tighten up the parsing of its integer argument, while at it.
> - A fix for '--show-linear-break-foo' in v1.
> - A little cleanup in the handling of '--show-notes/--notes'.
>
>
> SZEDER Gábor (5):
> revision.h: turn rev_info.early_output back into an unsigned int
> revision.c: stricter parsing of '--no-{min,max}-parents'
> revision.c: stricter parsing of '--early-output'
> revision.c: use skip_prefix() in handle_revision_opt()
> revision.c: use skip_prefix() in handle_revision_pseudo_opt()
>
> revision.c | 87 +++++++++++++++++++++++++++++---------------------------------
> revision.h | 5 ++--
> 2 files changed, 44 insertions(+), 48 deletions(-)I noted a minor nit in the first commit message, but otherwise these all look good to me.
-Peff