[PATCHv2 2/5] revision.c: stricter parsing of '--no-{min,max}-parents'
- From
SZEDER Gábor <szeder.dev@gmail.com>
- Date
- Jun 9, 2017, 18:17 UTC
- Message-ID
- <20170609181733.6793-3-szeder.dev@gmail.com>
- In-Reply-To
- <20170609181733.6793-1-szeder.dev@gmail.com>
These two options are parsed using starts_with(), allowing things like 'git log --no-min-parents-foobarbaz' to succeed.
Use strcmp() instead.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> --- revision.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/revision.c b/revision.c index f88c14bab..2f37e1e3a 100644 --- a/revision.c +++ b/revision.c @@ -1812,11 +1812,11 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg revs->max_parents = 1; } else if (starts_with(arg, "--min-parents=")) { revs->min_parents = atoi(arg+14); - } else if (starts_with(arg, "--no-min-parents")) { + } else if (!strcmp(arg, "--no-min-parents")) { revs->min_parents = 0; } else if (starts_with(arg, "--max-parents=")) { revs->max_parents = atoi(arg+14); - } else if (starts_with(arg, "--no-max-parents")) { + } else if (!strcmp(arg, "--no-max-parents")) { revs->max_parents = -1; } else if (!strcmp(arg, "--boundary")) { revs->boundary = 1;
-- 2.13.0.420.g54001f015