[PATCH 5/8] submodule--helper: show usage for "-h"
- From
Jeff King <peff@peff.net>
- Date
- May 30, 2017, 05:16 UTC
- Message-ID
- <20170530051650.t2pa2fsvbb6qdut4@sigill.intra.peff.net>
- In-Reply-To
- <20170530050949.dkgu3u26qj6ycusy@sigill.intra.peff.net>
Normal users shouldn't ever call submodule--helper, but it doesn't hurt to give them a normal usage message if they try "-h".
Signed-off-by: Jeff King <peff@peff.net> --- The usage message isn't that helpful _either_, and I admit my ulterior motive is just to make the test at the end of this series pass. :)
I was tempted to actually dump the names from the commands array to stdout, but this command really is an internal helper. It's probably not worth spending time on such niceties.
builtin/submodule--helper.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index 566a5b6a6..a78b003c2 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -1222,9 +1222,8 @@ static struct cmd_struct commands[] = { int cmd_submodule__helper(int argc, const char **argv, const char *prefix) { int i; - if (argc < 2) - die(_("submodule--helper subcommand must be " - "called with a subcommand")); + if (argc < 2 || !strcmp(argv[1], "-h")) + usage("git submodule--helper <command>"); for (i = 0; i < ARRAY_SIZE(commands); i++) { if (!strcmp(argv[1], commands[i].cmd)) {
-- 2.13.0.613.g11c956365