git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 6/7] grep: un-break building with PCRE < 8.20

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
May 25, 2017, 20:05 UTC
Message-ID
<20170525200528.22037-7-avarab@gmail.com>
In-Reply-To
<20170525200528.22037-1-avarab@gmail.com>

Amend my change earlier in this series ("grep: add support for the PCRE v1 JIT API", 2017-04-11) to un-break the build on PCRE v1 versions earlier than 8.20.

The 8.20 release was the first release to have JIT & pcre_jit_stack in the headers, so a mock type needs to be provided for it on those releases.

Now git should compile with all PCRE versions that it supported before my JIT change.

I've tested it as far back as version 7.5 released on 2008-01-10, once I got down to version 7.0 it wouldn't build anymore with GCC 7.1.1, and I couldn't be bothered to anything older than 7.5 as I'm confident that if the build breaks on those older versions it's not because of my JIT change.

See the "un-break" change in this series ("grep: un-break building with PCRE < 8.32", 2017-05-10) for why this isn't squashed into the main PCRE JIT commit.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 grep.h | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/grep.h b/grep.h
index 3b948d9155..ce90969736 100644
--- a/grep.h
+++ b/grep.h
@@ -11,6 +11,9 @@
 #ifndef PCRE_STUDY_JIT_COMPILE
 #define PCRE_STUDY_JIT_COMPILE 0
 #endif
+#if PCRE_MAJOR <= 8 && PCRE_MINOR < 20
+typedef int pcre_jit_stack;
+#endif
 #else
 typedef int pcre;
 typedef int pcre_extra;
-- 
2.13.0.303.g4ebf302169
Previous: Ævar Arnfjörð Bjarmason
Message 8 of 8 in “PCRE v2, PCRE v1 JIT, log -P & fixes”
  1. 0/7 PCRE v2, PCRE v1 JIT, log -P & fixesÆvar Arnfjörð Bjarmason, May 25, 2017
  2. 1/7 grep: don't redundantly compile throwaway patterns under threadingÆvar Arnfjörð Bjarmason, May 25, 2017
  3. 2/7 grep: skip pthreads overhead when using one threadÆvar Arnfjörð Bjarmason, May 25, 2017
  4. 3/7 log: add -P as a synonym for --perl-regexpÆvar Arnfjörð Bjarmason, May 25, 2017
  5. 5/7 grep: un-break building with PCRE < 8.32Ævar Arnfjörð Bjarmason, May 25, 2017
  6. 7/7 grep: add support for PCRE v2Ævar Arnfjörð Bjarmason, May 25, 2017
  7. 4/7 grep: add support for the PCRE v1 JIT APIÆvar Arnfjörð Bjarmason, May 25, 2017
  8. 6/7 grep: un-break building with PCRE < 8.20Ævar Arnfjörð Bjarmason, May 25, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.